Update Bolt 11 official test vectors

[t-bast]

Add payment secrets (see lightning/bolts#887)
We'll wait for the next release, and then change the payment_secret field to be non-optional

[codecov-commenter]

Codecov Report

Merging #1870 (8d42235) into master (663094e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #1870   +/-   ##
======================================
  Coverage    8.96%   8.96%           
======================================
  Files         158     158           
  Lines       12330   12335    +5     
  Branches      530     515   -15     
======================================
+ Hits         1105    1106    +1     
- Misses      11225   11229    +4     

Impacted Files	Coverage Δ
...scala/fr/acinq/eclair/payment/PaymentRequest.scala	51.91% <0.00%> (-0.87%)	⬇️
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala	2.57% <0.00%> (-0.02%)	⬇️
...r-core/src/main/scala/fr/acinq/eclair/Eclair.scala	0.00% <0.00%> (ø)
...n/scala/fr/acinq/eclair/transactions/Scripts.scala	41.37% <0.00%> (+1.72%)	⬆️

[sstone]

it seems that the On mainnet, please send 0.00967878534 BTC for a list of items within one week, amount in pico-BTC test has not been updated, and we're missing the Invalid sub-millisatoshi precision test (it was missing before)

[t-bast]

we're missing the Invalid sub-millisatoshi precision test (it was missing before)

Good catch, it was missing because we actually didn't implement that check!
Done in 716a22e

[sstone]

LGTM, but we probably should wait until lightning/bolts#898 has been merged ?

[t-bast]

Yes sure, let's wait for the spec PR to be accepted before merging here.

[t-bast]

lightning/bolts#898 has just been merged, so we can merge this PR now.