Additional reestablish test #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was added to lightning-kmp where this case wasn't correctly handled: ACINQ/lightning-kmp#278 It is correctly handled by eclair, but an additional test doesn't hurt.
Codecov Report
@@ Coverage Diff @@
## master #1875 +/- ##
==========================================
+ Coverage 87.27% 87.28% +0.01%
==========================================
Files 159 159
Lines 11935 11935
Branches 466 466
==========================================
+ Hits 10416 10418 +2
+ Misses 1519 1517 -2
|
pm47
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added to lightning-kmp where this case wasn't correctly handled: ACINQ/lightning-kmp#278
It is correctly handled by eclair, but an additional test doesn't hurt.