New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add offer manager #2566
Merged
Merged
Add offer manager #2566
Commits on Feb 17, 2023
-
Because offers are a very generic mechanism, handling them can require interacting with an inventory system (do we actually have the quantity that the payer is requesting) or other such systems which do not have their place inside eclair. For this reason offer handlers must be implemented as plugins that communicate with the offer manager. On startup, the offer handlers must register their offers with the offer manager, the offer manager will then forward the invoice requests and blinded payments to the relevant offer handler for approval.
-
Commits on Feb 24, 2023
Commits on Mar 1, 2023
Commits on Mar 3, 2023
Commits on Mar 6, 2023
Commits on Mar 21, 2023
-
- remove unnecessary `Try` - rename `GetIncomingPaymentActor` commands - restore standard -> blinded failure check
-
-
-
-
-
-
Commits on Mar 22, 2023
Commits on Mar 27, 2023
-
Rename and document DummyBolt12Invoice
Dummy is usually used for test or invalid data, whereas here we're just storing a minimal version of the Bolt 12 invoice, so we rename it MinimalBolt12Invoice. We also add an explicit constructor for it that forces callers to provide the data we expect to store. Note that we remove the `features` field: using `nodeParams.features` could be incorrect if the invoice_request's features don't include some of our node's optional features. This is unused now anyway, but more future-proof this way.
-
This commit refactors the offer manager without any meaningful change in the business logic itself: - move types to a separate file to isolate codec details - make plugin data optional - add debug logs in failure cases - let plugin specify the `invoice_error` message - avoid repeated calls to `Behaviors.setup`
-
- split OfferManager tests - add more tests to the OfferManager - remove test duplication in MultiPartHandlerSpec - refactor BlindedPaymentSpec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.