Allow splicing on non dual-funded channels #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
splice-non-dual-fund-channel
branch
from
7ba4e76
to
e1f9447
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2727 +/- ##
==========================================
+ Coverage 85.74% 85.79% +0.05%
==========================================
Files 216 216
Lines 18017 18053 +36
Branches 759 794 +35
==========================================
+ Hits 15449 15489 +40
+ Misses 2568 2564 -4
|
t-bast
force-pushed
the
splice-non-dual-fund-channel
branch
from
e1f9447
to
c795912
Compare
We currently allow splicing on top of a channel that was created without using dual funding, but it results in an incorrect channel reserve being used post-splice.
This field only applies to the first funding index, so we rename it to make that explicit. Once a splice has happened, it will be ignored.
t-bast
force-pushed
the
splice-non-dual-fund-channel
branch
from
c795912
to
a061f2f
Compare
pm47
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently allow splicing on top of a channel that was created without using dual funding, but it results in an incorrect channel reserve being used post-splice.
Another approach would be to move the channel reserve field to each commitment instead of having the initial value in
localParamsandremoteParams. This way we would always explicitly store the value for local/remote reserves, which may make custom channel reserves (0-reserve) more explicitly dealt with as well. But the issue is that we still need to keep track of the requested values fromopen_channel/accept_channeland propagate them until aCommitmentis created, which requires a lot of codec changes without bringing much value. I think we should go with this simple change for now and we can always introduce per-commitment reserves later if it becomes really necessary.