Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume widely supported features #2732

Merged
merged 3 commits into from Sep 27, 2023
Merged

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Aug 29, 2023

lightning/bolts#1092 makes some features compulsory and lets us assume that other nodes have support for them.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #2732 (3d1e09e) into master (d274fc1) will decrease coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #2732      +/-   ##
==========================================
- Coverage   85.84%   85.81%   -0.03%     
==========================================
  Files         216      216              
  Lines       18053    18053              
  Branches      794      803       +9     
==========================================
- Hits        15498    15493       -5     
- Misses       2555     2560       +5     
Files Coverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala 93.35% <100.00%> (+0.04%) ⬆️
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 86.86% <100.00%> (+0.26%) ⬆️

... and 4 files with indirect coverage changes

@t-bast t-bast requested a review from pm47 September 21, 2023 14:52
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should set option_data_loss_protect, gossip_queries and option_static_remotekey as mandatory in reference.conf.

pm47
pm47 previously approved these changes Sep 26, 2023
lightning/bolts#1092 makes some features compulsory
and lets us assume that other nodes have support for them.
We now require at least `option_static_remotekey`.
@t-bast t-bast force-pushed the assume-widely-supported-features branch from 6c4618d to 3d1e09e Compare September 26, 2023 14:26
@t-bast t-bast requested a review from pm47 September 26, 2023 15:14
@t-bast t-bast merged commit 37f3fbe into master Sep 27, 2023
1 check passed
@t-bast t-bast deleted the assume-widely-supported-features branch September 27, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants