Allow specifying a bitcoin wallet with an empty name #2737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the distinction between not defining a bitcoin wallet name, and using an bitcoin wallet with an empty name.
This remains mostly backward compatible, as:
eclair.bitcoind.wallet
is undefined so we keep using the default loaded wallet as beforeeclair.bitcoind.wallet
, then eclair will use that wallet.eclair.bitcoind.wallet
undefined, and if bitcoin had only one wallet with a non-empty name, then eclair will fail right at startup with an explicit error