Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a bitcoin wallet with an empty name #2737

Merged
merged 3 commits into from Sep 21, 2023
Merged

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Sep 7, 2023

We make the distinction between not defining a bitcoin wallet name, and using an bitcoin wallet with an empty name.

This remains mostly backward compatible, as:

  • by default eclair.bitcoind.wallet is undefined so we keep using the default loaded wallet as before
  • if user already set eclair.bitcoind.wallet, then eclair will use that wallet.
  • only in the case where the user left eclair.bitcoind.wallet undefined, and if bitcoin had only one wallet with a non-empty name, then eclair will fail right at startup with an explicit error

By default the configuration key for the wallet name is undefined, in
this case we use the default loaded wallet.
@pm47 pm47 requested a review from t-bast September 7, 2023 15:33
@codecov-commenter
Copy link

Codecov Report

Merging #2737 (91b3286) into master (8d42052) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
+ Coverage   85.85%   85.92%   +0.06%     
==========================================
  Files         215      215              
  Lines       17823    17824       +1     
  Branches      761      796      +35     
==========================================
+ Hits        15302    15315      +13     
+ Misses       2521     2509      -12     
Files Changed Coverage Δ
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala 74.85% <ø> (ø)
.../scala/fr/acinq/eclair/blockchain/Monitoring.scala 100.00% <100.00%> (ø)
...chain/bitcoind/rpc/BasicBitcoinJsonRPCClient.scala 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Co-authored-by: Bastien Teinturier <31281497+t-bast@users.noreply.github.com>
@pm47 pm47 merged commit 4e339aa into master Sep 21, 2023
1 check passed
@pm47 pm47 deleted the optional-wallet-name branch September 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants