Use bumpforceclose RPC to also bump remote commit fees
#2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
bump-remote-commit
branch
from
c957921
to
eb3bd25
Compare
pm47
reviewed
Sep 18, 2023
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/fee/OnChainFeeConf.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
Outdated
Show resolved
Hide resolved
pm47
previously approved these changes
Sep 19, 2023
We want to be able to bump a force-close regardless of which commitment was published. If the remote commitment is in our mempool, we will use our anchor on that commit tx to bump the fees.
By attaching an underlying `Int` specifically used for comparison.
t-bast
force-pushed
the
bump-remote-commit
branch
from
351ab82
to
97eb72a
Compare
|
Rebased. |
pm47
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #2743
When manually bumping the fees of a force-close (to help wallet users recover their funds more quickly), we also want to handle the case where they were the one publishing the commit tx and bump their remote commit. It can also be helpful for node operators who set
eclair.on-chain-fees.spend-anchor-without-htlcs = falseand want to recover their liquidity on a case-by-case basis.We also fix two issues in #2743:
ConfirmationPriority, which meansfastwasn't replacing a previousmediumorslow