Add support for sciddir_or_pubkey #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomash-acinq
force-pushed
the
sciddir_or_pubkey
branch
from
6c662a3
to
bfff706
Compare
thomash-acinq
force-pushed
the
sciddir_or_pubkey
branch
from
bfff706
to
49416e2
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2752 +/- ##
==========================================
+ Coverage 85.82% 85.85% +0.03%
==========================================
Files 216 216
Lines 18126 18158 +32
Branches 771 760 -11
==========================================
+ Hits 15556 15590 +34
+ Misses 2570 2568 -2
|
|
Can you rebase this PR before I start reviewing it? |
thomash-acinq
force-pushed
the
sciddir_or_pubkey
branch
from
06ec4b6
to
49f12e4
Compare
|
Rebased |
Offers (lightning/bolts#798) allow nodes to be identified using either the public key or a pair channel id and direction. The goal is to save bytes as channel id and direction only use 9 bytes instead of 33 for a public key.
thomash-acinq
force-pushed
the
sciddir_or_pubkey
branch
from
49f12e4
to
686c16f
Compare
t-bast
reviewed
Nov 7, 2023
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/OfferCodecs.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/OfferTypes.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/message/Postman.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/Invoice.scala
Outdated
Show resolved
Hide resolved
t-bast
reviewed
Nov 10, 2023
eclair-core/src/main/scala/fr/acinq/eclair/payment/send/Recipient.scala
Outdated
Show resolved
Hide resolved
This is just an automated renaming: * PaymentBlindedRoute -> PaymentBlindedContactInfo * ResolvedPaymentBlindedRoute -> PaymentBlindedRoute
Remove parameter duplication by using a private class.
|
I've added your commits, I've just changed two comments which I thought could be misleading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offers (lightning/bolts#798) allow nodes to be identified using either the public key or a pair channel id and direction. The goal is to save bytes as channel id and direction only use 9 bytes instead of 33 for a public key.