Remove ChannelFeatures->ChannelType conversion
#2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ChannelFeatures`->`ChannelType` conversion is problematic for the following reasons: - It creates an implicit bidirectional mapping between the two classes, which is illogical and error-prone because both directions must be kept in sync. - Not only must the conversions be kept in sync, it must also be stable over time. - From the spec p.o.v., the scope of `ChannelType` is really limited to channel opening negotiation, while we currently make it a permanent concept. - It has weird semantic side effects where we would check channel types in places where we really meant to check commitment formats.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2753 +/- ##
==========================================
+ Coverage 85.75% 85.82% +0.06%
==========================================
Files 216 216
Lines 18061 18070 +9
Branches 743 756 +13
==========================================
+ Hits 15488 15508 +20
+ Misses 2573 2562 -11
|
t-bast
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ChannelFeatures->ChannelTypeconversion is problematic for the following reasons:ChannelTypeis really limited to channel opening negotiation, while we currently make it a permanent concept.