Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local dust limit in local commit fee computation #2765

Merged
merged 1 commit into from Nov 3, 2023
Merged

Use local dust limit in local commit fee computation #2765

merged 1 commit into from Nov 3, 2023

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Oct 16, 2023

Whenever we use the local commit, we must use the local dust limit to trim HTLCs. Similarly, whenever we use the remote commit, we must use the remote dust limit.

@t-bast
Use local dust limit in local commit fee computation
ebe36c7 
Whenever we use the local commit, we must use the local dust limit to
trim HTLCs. Similarly, whenever we use the remote commit, we must use
the remote dust limit.
@t-bast t-bast requested a review from pm47 October 16, 2023 09:10
pm47
pm47 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed there must be symmetry between canSendAdd and canReceiveAdd.

@t-bast t-bast merged commit a3d90ad into master Nov 3, 2023
1 check passed
@t-bast t-bast deleted the local-dust-limit-htlc-receive branch November 3, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm47 pm47 pm47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t-bast @pm47