Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for quiescence back ported from lightning-kmp #2779

Merged
merged 6 commits into from Jan 10, 2024

Conversation

remyers
Copy link
Contributor

@remyers remyers commented Nov 14, 2023

This PR fixes some issues we found while porting quiescence to lightning-kmp.

We might find more changes, so this should stay in draft until we also have splicing with htlcs ported.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61f1e1f) 85.85% compared to head (e2c1308) 85.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2779   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         216      216           
  Lines       18188    18196    +8     
  Branches      780      786    +6     
=======================================
+ Hits        15615    15622    +7     
- Misses       2573     2574    +1     
Files Coverage Δ
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 85.94% <100.00%> (+0.08%) ⬆️

... and 5 files with indirect coverage changes

@t-bast t-bast marked this pull request as ready for review January 9, 2024 16:18
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should integrate this PR. Github doesn't show me the action to restart the failed CI, maybe you'll need to rebase for that? There shouldn't be any conflict.

@remyers remyers merged commit a9b5903 into ACINQ:master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants