Add require_confirmed_inputs to RBF messages
#2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
rbf-require-confirmed-inputs
branch
from
cb172a0
to
a2f49fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2783 +/- ##
==========================================
+ Coverage 85.85% 85.89% +0.04%
==========================================
Files 216 216
Lines 18188 18201 +13
Branches 780 776 -4
==========================================
+ Hits 15615 15634 +19
+ Misses 2573 2567 -6
|
This was missing from the spec, but is more flexible and clearer than inheriting values from the previous attempt. Fixes #2782
t-bast
force-pushed
the
rbf-require-confirmed-inputs
branch
from
a2f49fc
to
5aa515d
Compare
pm47
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing from the spec, but is more flexible and clearer than inheriting values from the previous attempt. The dual funding specification added this in lightning/bolts@27ffef4
Fixes #2782