Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitcoinheaders.net v2 format #2787

Merged
merged 1 commit into from Dec 4, 2023
Merged

Use bitcoinheaders.net v2 format #2787

merged 1 commit into from Dec 4, 2023

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Nov 29, 2023

The format used by bitcoinheaders.net is changing to use whole bytes instead of nibles, which is easier to parse. We start using the v2 format exclusively, which will allow deprecating the previous format.

Thanks @TheBlueMatt for notifying us.

Fixes #2786

The format used by bitcoinheaders.net is changing to use whole bytes
instead of nibles, which is easier to parse. We start using the v2 format
exclusively, which will allow deprecating the previous format.

Fixes #2786
@t-bast t-bast requested a review from remyers November 29, 2023 17:17
@codecov-commenter
Copy link

Codecov Report

Merging #2787 (886f09c) into master (e73c1cf) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2787      +/-   ##
==========================================
+ Coverage   85.83%   85.90%   +0.06%     
==========================================
  Files         216      216              
  Lines       18169    18166       -3     
  Branches      753      756       +3     
==========================================
+ Hits        15596    15606      +10     
+ Misses       2573     2560      -13     
Files Coverage Δ
...q/eclair/blockchain/watchdogs/HeadersOverDns.scala 17.77% <0.00%> (+1.11%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@remyers remyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes and stepped through the tests to make sure I understood what it was doing. Looks good to me.

@t-bast t-bast merged commit d4a498c into master Dec 4, 2023
1 check passed
@t-bast t-bast deleted the bitcoin-headers-v2 branch December 4, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate bitcoinheaders to v2
3 participants