Add a funding fee budget #2808
Merged
Add a funding fee budget #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on #2780, with a slightly different implementation. The fee is checked right after calling `fundrawtransaction`, which makes it work for both the single and dual funding cases. Also we use the `feeBudget` terminology instead of `maxFee`.
t-bast
reviewed
Jan 10, 2024
pm47
force-pushed
the
funding-fee-budget
branch
from
1dd4222
to
5534091
Compare
t-bast
approved these changes
Jan 10, 2024
t-bast
added a commit
that referenced
this pull request
Feb 29, 2024
This release introduces a few API changes: - `bumpforceclose` can be used to make a force-close confirm faster, by spending the anchor output (#2743) - `open` now takes an optional parameter `--fundingFeeBudgetSatoshis` to define the maximum acceptable value for the mining fee of the funding transaction. This mining fee can sometimes be unexpectedly high depending on available UTXOs in the wallet (#2808) - `rbfopen` now takes a mandatory parameter `--fundingFeeBudgetSatoshis` with the same semantics as for `open` (#2808) - `payoffer` can be used to pay experimental Bolt 12 offers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #2780, with a slightly different implementation.
The fee is checked right after calling
fundrawtransaction, which makes it work for both the single and dual funding cases.Also we use the
feeBudgetterminology instead ofmaxFee.