Send batch_size on commit_sig retransmit
#2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we get disconnected after sending `commit_sig`, we will retransmit that message when reconnecting if our peer has not received it. When we have multiple commitments, we need to retransmit one message per commitment, and include the `batch_size` tlv. We incorrectly stored `commit_sig` without the `batch_size` tlv in the next remote commit field, and thus retransmitted without that tlv.
pm47
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get disconnected after sending
commit_sig, we will retransmit that message when reconnecting if our peer has not received it.When we have multiple commitments, we need to retransmit one message per commitment, and include the
batch_sizetlv.We incorrectly stored
commit_sigwithout thebatch_sizetlv in the next remote commit field, and thus retransmitted without that tlv.