Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable threshold on maximum anchor fee #2816

Merged
merged 2 commits into from Feb 5, 2024

Commits on Feb 2, 2024

  1. Add configurable threshold on maximum anchor fee

    We previously bumped up to 5% of our channel balance when no HTLCs were
    at risk. For large channels, 5% is an unreasonably high value. In most
    cases it doesn't matter, because the transaction confirms before we try
    to bump it to unreasonable levels. But if the commitment transaction
    was pruned and couldn't be relayed to miners, then eclair would keep
    trying to bump until it reached that threshold. We now restrict this to
    a value configurable by the node operator. Note that when HTLCs are at
    risk, we still bump up to the HTLC amount, which may be higher than the
    new configuration parameter: we want that behavior as a scorched earth
    strategy against pinning attacks.
    t-bast committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    7eca115 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Add feerate upper bound from fee estimator

    We add a new limit to the feerate used for fee-bumping, based on the
    fastest feerate returned by our fee estimator. It doesn't make sense
    to use much higher values, since this feerate should guarantee that
    the transaction is included in the next block.
    t-bast committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a8bd6ae View commit details
    Browse the repository at this point in the history