Fixed eclair-cli #354
Merged
Fixed eclair-cli #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed old `channels` case that shadowed the new one - `connect` case was using `open` method
* errors and validation are handled by the API * URL can now be overriden with -h option * added a verbose option to display logs * added a start message when no command is given to eclair cli * check that JQ is available * added a new `connect` service with distinct `pubkey`, `pubkey`, `port` params
dpad85
approved these changes
Jan 3, 2018
Local channels list should gives more information than just the channel id. Now this call also returns the remote node id and the state of the channel.
The JSON RPC API should be disabled by default because it enables possible attacks on the node. The user must be aware of this and has to enable it himself. The API also requires a user/password to be set in `eclair.conf`. If the API is enabled and the user/password are not set, the node can not be started. CORS is disabled.
Api authentication only checks the password, so eclair-cli doesn't require the user to provide a username. Help message is more concise.
Makes the color field more practical to handle and enable finer serialization with a more readable code. allnodes command in api now exports a list with node announcements.
This call can also filter the channels for a given nodeId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
channelscase that shadowed the new oneconnectcase was usingopenmethod