Enforce a minimum fee rate #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
reviewed
Apr 3, 2018
| @@ -36,6 +36,8 @@ eclair { | |||
| } | |||
| } | |||
|
|
|||
| min-feerate = 1 // minimum feerate in satoshis per byte | |||
There was a problem hiding this comment.
Do we really need to make this configurable?
There was a problem hiding this comment.
I think it is safer, otherwise if the minimum relay fee goes up in the bitcoin network we may end up with tx that cannot even be relayed
| @@ -129,7 +129,16 @@ class Setup(datadir: File, overrideDefaults: Config = ConfigFactory.empty(), act | |||
| val zmqConnected = Promise[Boolean]() | |||
| val tcpBound = Promise[Unit]() | |||
|
|
|||
| val defaultFeerates = FeeratesPerByte(block_1 = config.getLong("default-feerates.delay-blocks.1"), blocks_2 = config.getLong("default-feerates.delay-blocks.2"), blocks_6 = config.getLong("default-feerates.delay-blocks.6"), blocks_12 = config.getLong("default-feerates.delay-blocks.12"), blocks_36 = config.getLong("default-feerates.delay-blocks.36"), blocks_72 = config.getLong("default-feerates.delay-blocks.72")) | |||
| val minFeerate = config.getLong("min-feerate") | |||
| assert(minFeerate > 0, s"minimum fee rate cannnot be zero") | |||
There was a problem hiding this comment.
I would put this requirement in the FeeratesPerKw.apply() method
sstone
force-pushed
the
minimum-feerate
branch
2 times, most recently
from
0894770
to
f5a7e6a
Compare
Make sure that our fee rate is always above a minimum value, set by default at 2 satoshi/byte
Same value as bitcoin core's minimum relay fee
pm47
previously approved these changes
Apr 3, 2018
and require that `FeeratesPerByte` and `FeeratesPerKw` be always > 0
pm47
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that our fee rate is always above a minimum value, set by default at 1 satoshi/byte