make max-feerate-mismatch configurable and set default value to 500% #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
requested changes
Apr 11, 2017
| @@ -38,6 +38,10 @@ eclair { | |||
| fee-base-msat = 546000 | |||
| fee-proportional-millionth = 10 | |||
|
|
|||
| // mamixmum local vs remote feerate mismatch; 1.0 means 100% | |||
| @@ -38,6 +38,10 @@ eclair { | |||
| fee-base-msat = 546000 | |||
| fee-proportional-millionth = 10 | |||
|
|
|||
| // mamixmum local vs remote feerate mismatch; 1.0 means 100% | |||
| // actuel check is abs((local feerate - remote fee rate) / (local fee rate + remote fee rate)/2) > fee rate mismatch | |||
There was a problem hiding this comment.
I think that comment should rather be in the scaladoc of function isFeeDiffTooHigh
| @@ -29,12 +29,6 @@ object Globals { | |||
| * than this ratio. | |||
| */ | |||
| val UPDATE_FEE_MIN_DIFF_RATIO = 0.1 | |||
There was a problem hiding this comment.
should UPDATE_FEE_MIN_DIFF_RATIO also be increased?
There was a problem hiding this comment.
it is now in application.conf
there can be a significant gap between the fee rate estimated by different bitcoin clients (see estimatesmartfee) so we must set a reasonably high value for the threshold above which we consider htat local and remote fee rates are too different and close the channel.
it becomes symmetrical and easier to reason with, and also more forgiving.
sstone
force-pushed
the
wip-configurable-feerate-mismatch
branch
from
f571fda
to
801e8c2
Compare
pm47
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there can be a significant gap between the fee rate estimated by different bitcoin
clients (see estimatesmartfee) so we must set a reasonably high value for the threshold
above which we consider htat local and remote fee rates are too different and close the
channel.