PaymentRequest are generated in LocalPaymentHandler #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
requested changes
Apr 11, 2017
| @@ -93,6 +94,8 @@ trait Service extends Logging { | |||
| (router ? 'nodes).mapTo[Iterable[NodeAnnouncement]].map(_.map(_.nodeId)) | |||
| case JsonRPCBody(_, _, "genh", _) => | |||
| (paymentHandler ? 'genh).mapTo[BinaryData] | |||
| case JsonRPCBody(_,_, "genPaymentRequest", JInt(amountMsat) :: Nil) => | |||
There was a problem hiding this comment.
I'd prefer receive instead of genPaymentRequest
| def getPaymentRequest(amountMsat: Long, textarea: TextArea) = { | ||
| (paymentHandler ? 'genh).mapTo[BinaryData].map { h => | ||
| Platform.runLater(new Runnable() { | ||
| def getPaymentRequest(amountMsat: MilliSatoshi, textarea: TextArea) = { |
There was a problem hiding this comment.
getPaymentRequest -> receive would be more consistent with the send counterpart
| case NewPaymentRequest(amount) if amount.amount > 0 && amount.amount < 4294967295L => | ||
| val r = generateR | ||
| val h: BinaryData = Crypto.sha256(r) | ||
| val pr = s"${nodeParams.privateKey.publicKey}:${amount.amount}:${h.toString}" |
There was a problem hiding this comment.
Please isolate this in a static method of object LocalPaymentHandler for better testability.
|
|
||
| object LocalPaymentHandler { | ||
| def props(nodeParams: NodeParams) = Props(new LocalPaymentHandler(nodeParams)) | ||
| case class NewPaymentRequest(amountMsat: MilliSatoshi) |
There was a problem hiding this comment.
For more consistency:
NewPaymentRequest->ReceivePaymentCreatePayment->SendPayment
|
PR Updated with proposed changes. |
* LocalPaymentHandler needs NodeParams when created to access the node pubkey * Added a NewPaymentRequest message in LocalPaymentHandler. Amount is checked and if the amount is not valid a failure is sent * Added a genPaymentRequest service * PaymentRequest in the GUI are now generated by the payment handler
* filling the payment request field in the modal is now handled by the controller
dpad85
force-pushed
the
wip-paymentrequest
branch
from
ce521df
to
7cf22d4
Compare
pm47
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checked and if the amount is not valid a failure is sent