Add exclusive locks to channels sqlite db #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone
requested changes
Jan 2, 2019
| @@ -41,6 +41,8 @@ trait AuditDb { | |||
|
|
|||
| def stats: Seq[Stats] | |||
|
|
|||
| def close: Unit | |||
There was a problem hiding this comment.
Scala convention would be to use close() since this methods has side-effects
sstone
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there is no risk of corruption currently (concurrent writes would just fail with
SQLITE_BUSY), but with this we make sure that there is only one instance of eclair using the sameeclair.sqlitedb file at any time.From https://www.sqlite.org/pragma.html: