Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ping less aggressive #782

Merged
merged 6 commits into from
Jan 11, 2019
Merged

Make ping less aggressive #782

merged 6 commits into from
Jan 11, 2019

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Dec 13, 2018

It currently leads to too many disconnections, in part because the initial delay is too short (peer may be under heavy load when syncing).

@rorp
Copy link
Contributor

rorp commented Dec 19, 2018

Also it would be great to be able to configure whether eclair should close connections or not if it doesn't receive pongs.

@pm47
Copy link
Member Author

pm47 commented Dec 20, 2018

@rorp agree, the spec does make it optional:

A node sending a ping message:
[...]
if it doesn't receive a corresponding pong:
[...]
MAY terminate the network connection

@pm47 pm47 changed the title [WIP] Make ping less aggressive Make ping less aggressive Jan 10, 2019
@pm47 pm47 requested a review from sstone January 10, 2019 16:48
@pm47 pm47 merged commit 10ea7bd into master Jan 11, 2019
@pm47 pm47 deleted the delay-ping branch January 11, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants