Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip witnesses of interactive tx parents #542

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Sep 27, 2023

We can safely remove the witness data, it doesn't affect txid and saves space. There is a max size on transactions due to lightning message limits.

We can safely remove the witness data, it doesn't affect txid and saves space. There
is a max size on transactions due to lightning message limits.
@pm47 pm47 requested a review from t-bast September 27, 2023 09:36
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should add the same improvement to eclair 👍

@pm47 pm47 merged commit f69e2ed into master Sep 27, 2023
2 checks passed
@pm47 pm47 deleted the strip-tx-segwit-inputs branch September 27, 2023 11:29
pm47 added a commit to ACINQ/eclair that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants