Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip witness of interactive tx parents #2755

Merged
merged 3 commits into from Sep 29, 2023
Merged

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Sep 27, 2023

Equivalent to ACINQ/lightning-kmp#542.

@pm47 pm47 requested a review from t-bast September 27, 2023 15:31
@codecov-commenter
Copy link

Codecov Report

Merging #2755 (7fbfd45) into master (e3ba524) will increase coverage by 0.06%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #2755      +/-   ##
==========================================
+ Coverage   85.75%   85.82%   +0.06%     
==========================================
  Files         216      216              
  Lines       18061    18071      +10     
  Branches      743      765      +22     
==========================================
+ Hits        15488    15509      +21     
+ Misses       2573     2562      -11     
Files Coverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala 93.37% <100.00%> (+0.04%) ⬆️
...r/acinq/eclair/blockchain/fee/OnChainFeeConf.scala 95.00% <ø> (-0.24%) ⬇️
...cala/fr/acinq/eclair/channel/ChannelFeatures.scala 100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/Commitments.scala 96.82% <100.00%> (+<0.01%) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Helpers.scala 94.51% <100.00%> (+0.02%) ⬆️
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 85.92% <100.00%> (+0.62%) ⬆️
...q/eclair/channel/fsm/ChannelOpenSingleFunded.scala 93.46% <100.00%> (ø)
...inq/eclair/channel/fund/InteractiveTxBuilder.scala 91.47% <100.00%> (+0.10%) ⬆️
...cinq/eclair/channel/fund/InteractiveTxFunder.scala 92.24% <100.00%> (+0.06%) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 87.60% <100.00%> (ø)
... and 2 more

... and 5 files with indirect coverage changes

@pm47 pm47 force-pushed the strip-witness-interactive-tx branch from 7fbfd45 to d5e8821 Compare September 29, 2023 11:19
@pm47 pm47 requested a review from t-bast September 29, 2023 11:20
@pm47 pm47 merged commit e199d15 into master Sep 29, 2023
1 check passed
@pm47 pm47 deleted the strip-witness-interactive-tx branch September 29, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants