Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement option_simple_close #597

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Implement option_simple_close #597

wants to merge 3 commits into from

Commits on Mar 27, 2024

  1. Add option_simple_close feature bit and codecs

    @t-bast
    t-bast committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9bbf579 View commit details
    Browse the repository at this point in the history

  2. Add support for OP_RETURN closing scripts 

    The spec allows the closer to use an OP_RETURN output if their amount is
too low when using `option_simple_close`.
    @t-bast
    t-bast committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3fa7de6 View commit details
    Browse the repository at this point in the history

  3. Implement the option_simple_close protocol 

    We update the `Negotiating` state to exchange the `closing_complete` and
`closing_sig` messages, and allow RBF-ing previous transactions and
updating our closing script.

We stay in that state until one of the transactions confirms, or a force
close is detected. This is important to ensure we're able to correctly
reconnect and negotiate RBF candidates.
    @t-bast
    t-bast committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    48b7348 View commit details
    Browse the repository at this point in the history