Error when calling GetAssoc() on an empty recordset

[gavrochelegnou]

Hi, i'm having the following error :

Warning: array_keys() expects parameter 1 to be array, boolean given in /media/psf/WWW/ocms/include/adodb5/adodb.inc.php on line 3437

When i do a query that returns no row
$co->getAssoc('SELECT a,b FROM table WHERE 0')

Thanks a lot

[gavrochelegnou]

I think the problem comes from this commit :
32a479a
When no rows are returned from the query $this->fields is not an array

[gavrochelegnou]

Just created a pull request to test if $this->fields is an array, but i don't know if there is a better way to do it ?
#163

[mnewnham]

Could you give your driver and adodb version please.

This looks to be a regression error in the mysqli driver in ADOdb 5.19 onwards.

Succeeds in oci8po, mysqli,mssqlnative in version 5.18
Succeeds in oci8po,mssqlnative version 5.19
Fails in mysqli version 5,19

[gavrochelegnou]

I had the problem with mysqli in 5.20

[mnewnham]

It looks like the problem is that the mysqli driver returns null in the 'fields' index in the recordset
for an empty query, while other drivers return array()., @dregad do you remember anything about this?

[dregad]

Not off the top of my head but I'll have a look tomorrow, maybe run git bisect too to identify the offending commit.

[mnewnham]

I agree that the problem is caused by commit 32a479a , but I think a more simple way would be

$cols = $this->_numOfFields;
if ($cols < 2) {
    return false;
}

if (!$this->fields)
    /*
   * Empty recordset, convert to empty array
   */
    return array();

$numIndex = blah,blah,blah

[dregad]

@gavrochelegnou The issue is fixed in commit 453f080 following @mnewnham's suggested implementation which I believe is more efficient than the one you proposed.

Feel free to patch your local installation, until I v5.20.1 is released officially.

Note that I confirmed this behavior on mysql(i) and pgsql, did not test on other drivers but most likely the problem is the same.

[gavrochelegnou]

Thanks a lot for your fast fix and awesome project !