Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sqlite metaType mappings (map X to Blob instead of Varchar) #177

Closed
mnewnham opened this issue Dec 29, 2015 · 3 comments
Closed

Fix Sqlite metaType mappings (map X to Blob instead of Varchar) #177

mnewnham opened this issue Dec 29, 2015 · 3 comments
Labels
enhancement sqlite The SQLite Database (Tier 1)
Milestone
v5.21.0

Comments

@mnewnham
Copy link
Contributor

Currently, the metaType 'X', which represents blob fields in all other databases, is mapped to a varchar(250) field in the sqlite3 driver. Whilst the flexible typing in the sqlite database means that this is not necessarily an issue , I believe for consistency with other databases, It should map to a blob field.
@mnewnham mnewnham added question sqlite The SQLite Database (Tier 1) labels Dec 29, 2015
@dregad
Copy link
Member

dregad commented Dec 29, 2015

I think achieving consistency across drivers should be one of our goals.

Looks like sqlite/sqlite3 are in fact using the generic datadict driver (_adodb_getdriver) function.

Maybe the generic driver needs to be changed ? That could cause backwards compatibility issues though.

@mnewnham
Copy link
Contributor Author

mnewnham commented Jan 5, 2016

I think we need to use an sqlite specific metaType function with the correct type mapping and leave the default one pointing to varchar which is pretty generic, as there is a bit of difference in the names of text fields across databases.

@dregad
Copy link
Member

dregad commented Jan 6, 2016

Fine with me.

mnewnham added a commit that referenced this issue Feb 1, 2016
@mnewnham
Sqlite Metatypes mapped incorrectly #177
e7d0281 
Sqlite datahases have very limited datatypes. The metaType
function defaults to the standard version which is based on 
the mysql standards. The new driver specific version provides
a metatype mapping based on the sqlite datatype affinities
dregad pushed a commit that referenced this issue Feb 4, 2016
@mnewnham @dregad
Sqlite Metatypes mapped incorrectly #177
cc90b1c 
Sqlite datahases have very limited datatypes. The metaType
function defaults to the standard version which is based on
the mysql standards. The new driver specific version provides
a metatype mapping based on the sqlite datatype affinities
@dregad dregad added this to the v5.21 milestone Feb 4, 2016
@dregad dregad changed the title Should Sqlite map metaType X to a blob field instead of Varchar Fix Sqlite metaType mappings (map X to Blob instead of Varchar) Feb 4, 2016
@dregad dregad closed this as completed Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement sqlite The SQLite Database (Tier 1)
Projects
None yet
Milestone
v5.21.0
Development

No branches or pull requests
2 participants
@dregad @mnewnham