Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setConnectionParameter method does not accept multiple parameters with same key value #187

Closed
mnewnham opened this issue Jan 7, 2016 · 0 comments
Closed

setConnectionParameter method does not accept multiple parameters with same key value #187

mnewnham opened this issue Jan 7, 2016 · 0 comments
Assignees
@mnewnham
Labels
enhancement
Milestone
v5.21.0

Comments

@mnewnham
Copy link
Contributor

mnewnham commented Jan 7, 2016

The setConnectionParameter(key,value) method only accepts a single unique value, but in mysql, parameters with the same key can be 'stacked', e.g.

$db->setConnectionParameter(MYSQLI_READ_DEFAULT_GROUP, "max_allowed_packet=50M");
$db->setConnectionParameter(MYSQLI_READ_DEFAULT_GROUP, "default-character-set=big5");

This change allows this to occur
@mnewnham mnewnham self-assigned this Jan 7, 2016
@mnewnham mnewnham added this to the v5.21 milestone Jan 7, 2016
mnewnham added a commit that referenced this issue Jan 7, 2016
@mnewnham
Change to setConnectionParameter so keys can be stacked. see #187
5f16c33
@mnewnham mnewnham closed this as completed Jan 7, 2016
mnewnham added a commit that referenced this issue Jan 7, 2016
@mnewnham @dregad
mysql: allow multiple connection parameters with same key
439c700 
The setConnectionParameter(key,value) method only accepts a single
unique value, but in mysql, parameters with the same key can be
'stacked', e.g.

$db->setConnectionParameter(MYSQLI_READ_DEFAULT_GROUP, "max_allowed_packet=50M");
$db->setConnectionParameter(MYSQLI_READ_DEFAULT_GROUP, "default-character-set=big5");

Method has been changed to allow this to occur.

Fixes #187
@dregad dregad mentioned this issue Mar 13, 2021
Closed
@dregad dregad mentioned this issue Feb 19, 2022
Closed
dregad added a commit that referenced this issue Feb 20, 2022
@dregad
Fix regression on mysqli::setConnectionParameter()
f08327a 
Restore ability to set the same parameter multiple times (see #187),
that was removed in 5.21.1 [1].

Fixes #803

[1]: commits aa20883 and
     27ec622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnewnham mnewnham

Labels
enhancement
Projects
None yet
Milestone
v5.21.0
Development

No branches or pull requests
1 participant
@mnewnham