Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkBind is broken in 5.20.X #199

Closed
10n opened this issue Feb 17, 2016 · 0 comments
Closed

BulkBind is broken in 5.20.X #199

10n opened this issue Feb 17, 2016 · 0 comments
Labels
Milestone

Comments

@10n
Copy link
Contributor

10n commented Feb 17, 2016

In Execute method after $array_2d is detected as TRUE (line:1109) the param count validation is not compatible with bulk bind:

            $sqlarr = explode('?',$sql);
            $nparams = sizeof($sqlarr)-1;
            // Make sure the number of parameters provided in the input
            // array matches what the query expects
            if ($nparams != count($inputarr)) { 
10n added a commit to 10n/ADOdb that referenced this issue Feb 17, 2016
Fix for: BulkBind is broken in 5.20.X ADOdb#199
@dregad dregad added the bug label Mar 24, 2016
@dregad dregad added this to the v5.21 milestone Mar 24, 2016
@dregad dregad closed this as completed in a17bdc7 Mar 24, 2016
dregad pushed a commit that referenced this issue Mar 30, 2016
Before checking the number of arguments if array_2d is detected then we
should make sure all list of arguments have the same size.

Fixes #199, #200

Signed-off-by: Damien Regad <dregad@mantisbt.org>

Changes to original patch: fixed whitespace and rewrote commit message.
@dregad dregad modified the milestones: v5.20.4, v5.21 Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants