Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDO SQL server fetchfield method fails if default field number requested #251

Closed
mnewnham opened this issue May 20, 2016 · 0 comments
Closed
Assignees
Labels
bug mssqlnative Native driver for SQL Server driver (Tier 1) pdo The PHP PDO Driver (Tier 2)
Milestone

Comments

@mnewnham
Copy link
Contributor

The method fetchField accepts a value of -1, with which it is supposed to return the first entry. If this method is used in the pdo_sqlsrv driver, the method crashes with an 'invalid offset' error.

@mnewnham mnewnham added bug mssqlnative Native driver for SQL Server driver (Tier 1) pdo The PHP PDO Driver (Tier 2) labels May 20, 2016
@mnewnham mnewnham added this to the v5.21 milestone May 20, 2016
@mnewnham mnewnham self-assigned this May 20, 2016
mnewnham added a commit that referenced this issue May 20, 2016
…type, see #234

1. The fetchfield method fails if a default value (-1) is sent to the method
2. SQL Server returns driver specific field information which should be used 
instead of the generic PDO data types
3. Field object information is cached to reduce repetitive reads of field data
information
dregad pushed a commit to dregad/ADOdb that referenced this issue May 27, 2016
1. The fetchfield method fails if a default value (-1) is sent to the
   method
2. SQL Server returns driver specific field information which should be
   used instead of the generic PDO data types
3. Field object information is cached to reduce repetitive reads of
   field data information

Fixes ADOdb#251, ADOdb#234
dregad added a commit to dregad/ADOdb that referenced this issue May 27, 2016
Follow-up on c4b339cb12b9ccdea54a1ff42aa853d89e97188b. See ADOdb#251, ADOdb#234.
dregad pushed a commit to dregad/ADOdb that referenced this issue Aug 28, 2016
1. The fetchfield method fails if a default value (-1) is sent to the
   method
2. SQL Server returns driver specific field information which should be
   used instead of the generic PDO data types
3. Field object information is cached to reduce repetitive reads of
   field data information

Fixes ADOdb#251, ADOdb#234
dregad added a commit to dregad/ADOdb that referenced this issue Aug 28, 2016
Follow-up on c4b339cb12b9ccdea54a1ff42aa853d89e97188b. See ADOdb#251, ADOdb#234.
dregad pushed a commit that referenced this issue Aug 31, 2016
1. The fetchfield method fails if a default value (-1) is sent to the
   method
2. SQL Server returns driver specific field information which should be
   used instead of the generic PDO data types
3. Field object information is cached to reduce repetitive reads of
   field data information

Fixes #251, #234
dregad added a commit that referenced this issue Aug 31, 2016
Follow-up on c4b339cb12b9ccdea54a1ff42aa853d89e97188b. See #251, #234.
@dregad dregad closed this as completed in 092a2c9 Sep 7, 2016
dregad added a commit that referenced this issue Sep 7, 2016
Follow-up on 092a2c9.
Addresses review comments in PR #249.

Fixes #251, #234.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mssqlnative Native driver for SQL Server driver (Tier 1) pdo The PHP PDO Driver (Tier 2)
Projects
None yet
Development

No branches or pull requests

1 participant