Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.1 compatibility #257

Closed
lolli42 opened this issue Jul 5, 2016 · 0 comments
Closed

PHP 7.1 compatibility #257

lolli42 opened this issue Jul 5, 2016 · 0 comments
Assignees
@dregad
Labels
bug PHP7 PHP 7.x compatibility issues xml schema
Milestone
v5.20.5

Comments

@lolli42
Copy link
Contributor

lolli42 commented Jul 5, 2016

Linting (php -l) on php 7.1 alpha2 shows a couple of issues like:

PHP Fatal error: Cannot unset $this in ./adodb-xmlschema.inc.php on line 160
lolli42 added a commit to lolli42/ADOdb that referenced this issue Jul 5, 2016
@lolli42
[BUGFIX] PHP 7.1 compatibility
e2dbdec 
resolve ADOdb#257
unset($this) throws a fatal error on linting. Use internal
garbage collection to clean up old objects instead.
@lolli42 lolli42 mentioned this issue Jul 5, 2016
Closed
@dregad dregad added this to the v5.20.5 milestone Aug 2, 2016
@dregad dregad self-assigned this Aug 2, 2016
dregad pushed a commit that referenced this issue Aug 10, 2016
@lolli42 @dregad
xml: remove calls to 'unset($this)' (PHP 7.1 compatibility)
659b274 
unset($this) throws a fatal error on linting. Use internal
garbage collection to clean up old objects instead.

Fixes #257

Signed-off-by: Damien Regad <dregad@mantisbt.org>

As per PHP manual, "It is not possible to unset $this inside an object
method since PHP 5." (see http://php.net/manual/function.unset, Notes
section)
@dregad dregad closed this as completed Aug 10, 2016
@dregad dregad added the PHP7 PHP 7.x compatibility issues label Aug 11, 2016
@TheToolbox TheToolbox mentioned this issue Sep 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dregad dregad

Labels
bug PHP7 PHP 7.x compatibility issues xml schema
Projects
None yet
Milestone
v5.20.5
Development

Successfully merging a pull request may close this issue.

[BUGFIX] PHP 7.1 compatibility lolli42/ADOdb
2 participants
@dregad @lolli42