mssqlnative: drop/alter column not working if column has default constraint #290
Labels
Milestone
Comments
|
@obmsch Thanks for your contribution. If you can, it would be more convenient for us if you could provide your patch as a pull request instead of an attachment. For the record: this originated from discussion at https://www.mantisbt.org/bugs/view.php?id=21883 @mnewnham it would be great if you could take a look at this. |
|
Revised patch attached, with handles altering the column with no 'new' default and |
|
As @dregad mentioned, if you could provide us a pull request it would be great. I don't have the means to work with this patch file at the moment. |
dregad
pushed a commit
that referenced
this issue
Dec 17, 2016
With MSSQL it is not possible to drop or alter a column with an existing constraint. The constraint has to be removed before the operation takes place. In 'datadict-mssqlnative.inc.php' AlterColumnSQL is commented out and DropColumnSQL doesn't care. This tries to fix the problem with the smallest possible impact: - Fix DropColumnSQL(), to allow the drop even with a constraint on that given column. We drop, so any default doesn't matter. - Fix AlterColumnSql(), to allow changes if (and only if !) either a 'new' default is given for an existing default, or there is no existing one at all. So something like 'ALTER TABLE t ALTER COLUMN c INT NOT NULL' with an existing constraint on c will still fail since it can't be determined if keeping or removing the constraint is implied here. Fixes #290 via #297 Changes to original commit: - split long lines, whitespace - Added commit message text from issue #290's description Signed-off-by: Damien Regad <dregad@mantisbt.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With MSSQL it is not possible to drop or alter a column with an existing constraint.
This constraint has to be removed before the drop or alter takes place.
In 'datadict-mssqlnative.inc.php' AlterColumnSQL is commented out and DropColumnSQL
doesn't care.
The attached patch tries to remedy this with the smallest possible impact.
Fix DropColumnSQL, to allow the drop even with a constraint on that given column.
We drop so any default doesn't matter.
Fix AlterColumnSql, to allow changes if and only if(!) either a 'new' default is
given for an existing default, or there is no existing one at all. So something
like 'ALTER TABLE t ALTER COLUMN c INT NOT NULL' with an existing constraint on c
will still fail. I can't decide, if keep or remove the constraint is implied here.
datadict-mssqlnative.inc.php.patch.txt
The text was updated successfully, but these errors were encountered: