You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In drivers/adodb-mssqlnative.inc.php
method _close() contains a bug causing this method do nothing if(is_object($this->_queryID)) {
is wrong because $this->_queryID is not an object but a resource (probable copy/paste from PDO version)
it should be if(is_resource($this->_queryID)) {
It cause extra cursor left open, and if there's multiple big query on the same DB blocs through a getrow it can cause a deadlock, it's not common on normal operation but I've spend hours on a such bug due to a bugged query. Could be an issue on long worker too.
The text was updated successfully, but these errors were encountered:
I apologize. I thought that there was a different issue to what we have originally discussed. I have pushed a fix directly into master and 5.20 for the next hotfix. if there are no other issues, please close this.
Fix#590 closes the connection early, making affected_rows() fail. In addition, the value returned for an invalid query (-1) does not conform to the ADOdb standard (false). Affected Rows is now retrieved immediately after query execution and stored for later use.
In drivers/adodb-mssqlnative.inc.php
method _close() contains a bug causing this method do nothing
if(is_object($this->_queryID)) {
is wrong because $this->_queryID is not an object but a resource (probable copy/paste from PDO version)
it should be
if(is_resource($this->_queryID)) {
It cause extra cursor left open, and if there's multiple big query on the same DB blocs through a getrow it can cause a deadlock, it's not common on normal operation but I've spend hours on a such bug due to a bugged query. Could be an issue on long worker too.
The text was updated successfully, but these errors were encountered: