Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid xmlschema03.dtd #595

Closed
peterdd opened this issue Jan 10, 2020 · 0 comments
Closed

invalid xmlschema03.dtd #595

peterdd opened this issue Jan 10, 2020 · 0 comments

Comments

@peterdd
Copy link
Contributor

peterdd commented Jan 10, 2020

The xmlschema03.dtd declares how a valid xmlschema03 xml file looks like.

The xmlschema03.dtd is not used by ADOdb source code as the parsing etc is done by adodb-xmlschema03.inc.php.

By running a validation of a given xmlschema03 xml file against a xmlschema03.dtd you can find errors in the xml that would be ignored by xmlschema03.inc.php. (see PR #592 and companion #593 for the older xmlschema)

This problem was also noted in the abandoned adodb-xmlschema project on sourceforge.net, see https://sourceforge.net/p/adodb-xmlschema/bugs/20/

Beside some required typo fixing, there are some field types allowed/handled by xmlschema03.inc.php / ADOdb datadict like 'XL', that are not (yet) part of the xmlschema03.dtd

Also unsure if all I1, I2, I4, I8 for setting the bytes used for integer storage must be part of xmlschema03.dtd

See PR #594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants