PHP 8.0 compatibility: function 'setConnectionParameter' (mysqli)

[deining]

Versions:

• php 8.0.3
• mysql Ver 15.1 Distrib 10.5.9-MariaDB
• adodb 5.21.0

Following your advice given in #686, I tried to use function setConnectionParameter.
Unfortunately, this leads to another error:

Stackstrace:

Uncaught TypeError: mysqli_options(): Argument #2 ($option) must be of type int, string given in /my_path/adodb/drivers/adodb-mysqli.inc.php:148
Stack trace:
#0 /my_path/adodb/drivers/adodb-mysqli.inc.php(148): mysqli_options()
#1 /my_path/adodb/adodb.inc.php(705): ADODB_mysqli->_connect()
#2 /my_path/my.php(10): ADOConnection->Connect()
#3 {main}\n  thrown in /my_path/adodb/drivers/adodb-mysqli.inc.php on line 148

My code looks like:

include('adodb/adodb.inc.php');
$db = ADONewConnection('mysqli');
$db->setConnectionParameter('CharacterSet','utf8mb4');
$db->Connect("host", "user", "passphrase", "database");

Thanks for investigating the issue.

[dregad]

You need to use the predefined constants to identify the option, and not some arbitrary string. In your case:

$db->setConnectionParameter(MYSQLI_SET_CHARSET_NAME,'utf8mb4');

MYSQLI_SET_CHARSET_NAME

That said, the code should not choke on this, so I'll keep this open to fix this

[deining]

You need to use the predefined constants to identify the option

Thanks for clarification. It now works as expected.

That said, the code should not choke on this, so I'll keep this open to fix this

I agree. Thanks for your efforts.

Another topic: The documentation of the setConnectionParameter function mentions usage with DB2 and SQl server databases only. Would be great if usage in case of MySQL (and PostgreSQL) were added, too.

[dregad]

Another topic: The documentation of the setConnectionParameter function mentions usage with DB2 and SQl server databases only. Would be great if usage in case of MySQL (and PostgreSQL) were added, too.

I was actually updating that as you posted... Please check again
https://adodb.org/dokuwiki/doku.php?id=v5:reference:connection:setconnectionparameter

[dregad]

@mnewnham I was wondering why you defined the setConnectionParameter() method as final (see #158, 2e72fe5), this prevents overriding it in a specific driver (mysqli in this case) to add error handling.

Of course we could also do the check in ADODB_mysqli::_connect() as well, but it seems cleaner to me to catch the error early. Thoughts ?

[mnewnham]

Clearly a mistake. Please revert

[dregad]

That said, the code should not choke on this, so I'll keep this open to fix this

PR #701 addresses the problem of ADODB_mysqli->_connect() throwing a TypeError (on PHP 8) or a Warning (on earlier PHP versions) when processing an invalid parameter.