Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: parameters of ADOrecordset __construct() are incompatible with drivers and other classes #772

Closed
mnewnham opened this issue Nov 27, 2021 · 1 comment
Closed

core: parameters of ADOrecordset __construct() are incompatible with drivers and other classes #772

mnewnham opened this issue Nov 27, 2021 · 1 comment
Assignees
@mnewnham
Labels
core ADOdb core (library and base classes)
Milestone
v5.22.0

Comments

@mnewnham
Copy link
Contributor

mnewnham commented Nov 27, 2021 •
edited

ADOrecordset::__construct() parameters are defined as mixed $queryId, while:

  1. the constructors of all drivers that extends this class are defined as mixed $queryId, optional mixed $mode
  2. The constructor of ADOrecordset_array() which extends ADOrecordset is defined as optional int

The parent and all classes that extend ADOrecordset should accept parameters of mixed $queryId, option mixed $mode
@mnewnham mnewnham added the core ADOdb core (library and base classes) label Nov 27, 2021
@mnewnham mnewnham added this to the v5.22.0 milestone Nov 27, 2021
@mnewnham mnewnham self-assigned this Nov 27, 2021
@mnewnham
Copy link
Contributor Author

See #57186f90 for fix info. (Labelled incorrectly)

dregad referenced this issue Dec 15, 2021
@mnewnham
Constructor parameters are incompatible across ADOrecordset definitio…
57186f9 
…ns, see #771

The constructor parameters vary slightly across various usages of ADOrecordset. This standardizes them
@dregad dregad mentioned this issue Jan 1, 2022
Closed
dregad pushed a commit that referenced this issue Jan 1, 2022
@dregad
Fix PHP ERROR: Uncaught ArgumentCountError
a61b2ce 
Too few arguments to function ADORecordSet_array::__construct(), 0
passed in adodb/adodb-csvlib.inc.php on line 79 and at least 1 expected.

Regression introduced by 57186f9

Fixes #772 (see PR #785)

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnewnham mnewnham

Labels
core ADOdb core (library and base classes)
Projects
None yet
Milestone
v5.22.0
Development

No branches or pull requests
1 participant
@mnewnham