Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memcache: default port should be used in server controller template #824

Closed
dregad opened this issue Mar 29, 2022 · 0 comments · Fixed by #816
Closed

memcache: default port should be used in server controller template #824

dregad opened this issue Mar 29, 2022 · 0 comments · Fixed by #816
Assignees
@dregad
Labels
bug caching Result set caching feature (memcache or file-based)
Milestone
v5.22.1

Comments

@dregad
Copy link
Member

dregad commented Mar 29, 2022

In 5.22.0, it became possible to define memcache servers as array, specifying host, port and weight.

The ADODB_Cache_MemCache class defines a $serverControllerTemplate which hardcodes the default port to 11211.

If a different value is defined globally in ADOConnection::$memCachePort it will be ignored.
@dregad dregad added bug caching Result set caching feature (memcache or file-based) labels Mar 29, 2022
@dregad dregad added this to the v5.22.1 milestone Mar 29, 2022
@dregad dregad self-assigned this Mar 29, 2022
@dregad dregad linked a pull request Mar 29, 2022 that will close this issue
Memcache bug fixes and improvements #816
Merged
dregad added a commit to dregad/ADOdb that referenced this issue Mar 29, 2022
@dregad
memcache: use default port in server controller template
67a7f00 
Fixes ADOdb#824
@dregad dregad mentioned this issue Mar 29, 2022
Merged
dregad added a commit to dregad/ADOdb that referenced this issue Mar 30, 2022
@dregad
memcache: use default port in server controller template
4cd1639 
Fixes ADOdb#824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dregad dregad

Labels
bug caching Result set caching feature (memcache or file-based)
Projects
None yet
Milestone
v5.22.1
Development

Successfully merging a pull request may close this issue.

Memcache bug fixes and improvements dregad/ADOdb
1 participant
@dregad