ensure $nrows and $offset parameters of SelectLimit are integers
#311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as is done (at least for `$nrows`) in the `SelectLimit` method of `Adodb/adodb.inc.php`. lowers the risk of SQL injection.
dregad
added a commit
that referenced
this pull request
Nov 25, 2017
The same is done (at least for `$nrows`) in the `SelectLimit` method of `Adodb/adodb.inc.php`. This lowers the risk of SQL injection. Fixes #311
|
Sorry I messed up while rewording the commit message and inadvertantly merged instead of squash. The actual fix is 7d43989 |
|
Doesn't this need doing for |
dregad
added
pdo
dregad
pushed a commit
to dregad/ADOdb
that referenced
this pull request
Mar 30, 2018
The `SelectLimit` function has a potential SQL injection vulnerability through the use of the `nrows` and `offset` parameters which are not forced to integers. This is a follow-up on ADOdb#311, and fixes all remaining drivers that do not use ADOConnection::SelectLimit(). Fixes ADOdb#401 Signed-off-by: Damien Regad <dregad@mantisbt.org> Original commits squashed, message reworded. Fixed whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as is done (at least for
$nrows) in theSelectLimitmethod ofAdodb/adodb.inc.php.lowers the risk of SQL injection.