-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing to bintray #9
Conversation
* Add publications to build.gradle * Add gradle-semantic-release configuration * Model travis.yml after gradle-semantic-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. A few suggestions/questions.
build.gradle
Outdated
'gradle-plugin': 'com.adtran.betablocker-plugin:com.adtran:scala-multiversion-plugin' | ||
] | ||
gpg { | ||
sign = System.env['GPG_PASS'] != null ? true : false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ternary seems pointless here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Was mostly for local testing. I can just set it to true now.
build.gradle
Outdated
} | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should delete this if it's unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Wasn't sure if we wanted to keep it around in case we needed to bring it back (guess we can always dig it out of commit history).
build.gradle
Outdated
ghToken = project.ghToken | ||
releaseAsset jar | ||
releaseAsset sourcesJar, name: "sources.jar", label: 'sources jar', contentType: 'application/zip' | ||
releaseAsset sourcesJar, name: "javadoc.jar", label: 'javadoc jar', contentType: 'application/zip' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-paste error? I think this should be releaseAsset javadocJar ...
def root = asNode() | ||
root.appendNode('description', 'Gradle plugin to build a project against multiple versions of scala') | ||
root.appendNode('name', "$artifact_group:$artifact_name") | ||
root.appendNode('url', 'https://github.com/ADTRAN/gradle-scala-multiversion-plugin') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to do XML manipulation here like this? Can these three fields go in pomConfig
and be set using the DSL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I was working from the bintray/gradle-bintray-plugin example. I'll check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at MavenPublication, using description
, name
, or url
directly isn't documented, so I'm inclined to leave it as is.
Take two on #8. I'm hitting some issues locally with publishing but I believe when its merged into master it should work out. It builds a snapshot locally and haven't found a way to fake that out to get fully through the process. I have verified
bintray
individually andrelease
does seem to be consuming GH_TOKEN properly.