Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing to bintray #9

Merged
merged 9 commits into from
May 23, 2018
Merged

Publishing to bintray #9

merged 9 commits into from
May 23, 2018

Conversation

rpocase
Copy link
Contributor

@rpocase rpocase commented May 23, 2018

Take two on #8. I'm hitting some issues locally with publishing but I believe when its merged into master it should work out. It builds a snapshot locally and haven't found a way to fake that out to get fully through the process. I have verified bintray individually and release does seem to be consuming GH_TOKEN properly.

* Add publications to build.gradle
* Add gradle-semantic-release configuration
* Model travis.yml after gradle-semantic-release
Copy link
Collaborator

@nathanalderson nathanalderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A few suggestions/questions.

build.gradle Outdated
'gradle-plugin': 'com.adtran.betablocker-plugin:com.adtran:scala-multiversion-plugin'
]
gpg {
sign = System.env['GPG_PASS'] != null ? true : false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ternary seems pointless here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Was mostly for local testing. I can just set it to true now.

build.gradle Outdated
}
}

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should delete this if it's unused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Wasn't sure if we wanted to keep it around in case we needed to bring it back (guess we can always dig it out of commit history).

build.gradle Outdated
ghToken = project.ghToken
releaseAsset jar
releaseAsset sourcesJar, name: "sources.jar", label: 'sources jar', contentType: 'application/zip'
releaseAsset sourcesJar, name: "javadoc.jar", label: 'javadoc jar', contentType: 'application/zip'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste error? I think this should be releaseAsset javadocJar ...

def root = asNode()
root.appendNode('description', 'Gradle plugin to build a project against multiple versions of scala')
root.appendNode('name', "$artifact_group:$artifact_name")
root.appendNode('url', 'https://github.com/ADTRAN/gradle-scala-multiversion-plugin')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to do XML manipulation here like this? Can these three fields go in pomConfig and be set using the DSL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I was working from the bintray/gradle-bintray-plugin example. I'll check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at MavenPublication, using description, name, or url directly isn't documented, so I'm inclined to leave it as is.

@rpocase rpocase merged commit 5061795 into master May 23, 2018
@rpocase rpocase deleted the publishing branch May 23, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants