Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute include #2

Closed
peci1 opened this issue Jun 11, 2023 · 1 comment
Closed

Absolute include #2

peci1 opened this issue Jun 11, 2023 · 1 comment

Comments

@peci1
Copy link
Contributor

peci1 commented Jun 11, 2023

https://github.com/torydebra/point_cloud2_filters/blob/1cc996bce2d8dcd261a73e14e7d496b75c48acbf/include/point_cloud2_filters/PassThroughFilterPointCloud2.hpp#L6

This is veeery bad for code reusability. Did you have any problems including filter_base.hpp in the standard way?
torydebra added a commit that referenced this issue Jun 13, 2023
@torydebra
fixing #2
5184dbb
@torydebra
Copy link
Collaborator

Yep this is terrible :D I had some problems and then forgot about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peci1 @torydebra