Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to delete fee payments through frontend for system admins #2153

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

WJSchuringa
Copy link

@WJSchuringa WJSchuringa self-assigned this May 9, 2024
@WJSchuringa WJSchuringa force-pushed the MA-68_system-admins-should-be-able-to-delete-fee-payments branch 2 times, most recently from ef3e534 to e7c1249 Compare May 10, 2024 07:23
@WJSchuringa WJSchuringa force-pushed the MA-68_system-admins-should-be-able-to-delete-fee-payments branch from e7c1249 to 8492f57 Compare May 10, 2024 07:31
@WJSchuringa WJSchuringa requested a review from WikiRik May 11, 2024 17:27
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I have two visual comments though.

Can we make the width bigger when the member has the ability to delete a fee payment? The button gets cut off right now;
chrome_2024-05-17_16 16 08

const updatedPayments = [...this.member.payments]
const index = updatedPayments.findIndex(p => p.id === fee.id)
updatedPayments.splice(index, 1)
this.member.payments = updatedPayments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should refresh the table as well, to prevent this behaviour after deleting the last fee payment;
chrome_2024-05-17_16 16 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants