reviews for AElf.Kernel.SmartContract

[loning]

No description provided.

[todo]

rename to GrpcCrossChainNodePlugin

AElf/src/AElf.CrossChain.Communication.Grpc/GrpcNodePlugin.cs

Lines 7 to 10 in c0a9236

	//TODO: rename to GrpcCrossChainNodePlugin
	public class GrpcNodePlugin : INodePlugin
	{
	private readonly IGrpcServePlugin _grpcServePlugin;

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

if TransactionExecutedEventData is only for Debug, TransactionExecutedEventData should also wrap in #DEBUG

AElf/src/AElf.Kernel.Core/SmartContractExecution/Events/TransactionExecutedEventData.cs

Lines 5 to 9 in c0a9236

	//TODO: if TransactionExecutedEventData is only for Debug, TransactionExecutedEventData should also wrap in #DEBUG
	public class TransactionExecutedEventData
	{
	public TransactionTrace TransactionTrace { get; set; }

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

a service should not mange status. what's this class for?

AElf/src/AElf.Kernel.Core/Txn/Application/TransactionPackingService.cs

Lines 6 to 9 in c0a9236

	//TODO: a service should not mange status. what's this class for?
	private bool _isTransactionPackable = true;
	public void EnableTransactionPacking()

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

if you are a CalculateAlgorithmService, why do you need to care about fork? one class does one thing

AElf/src/AElf.Kernel.SmartContract/Application/CalculateFeeStrategy/ICalculateAlgorithmService.cs

Lines 10 to 13 in c0a9236

	//TODO: if you are a CalculateAlgorithmService, why do you need to care about fork? one class does one thing
	void RemoveForkCache(List<BlockIndex> blockIndexes);
	void SetIrreversedCache(List<BlockIndex> blockIndexes);
	Task<long> CalculateAsync(int count);

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

we only need one strategy to calculate tx, read, write ... resources.

AElf/src/AElf.Kernel.SmartContract/Application/CalculateFeeStrategy/ICalculateCostStrategy.cs

Lines 15 to 18 in c0a9236

	//TODO: we only need one strategy to calculate tx, read, write ... resources.
	public interface ICalculateTxCostStrategy : ICalculateCostStrategy
	{

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

it looks not OOP

AElf/src/AElf.Kernel.SmartContract/Application/CalculateFeeStrategy/ICalculateWay.cs

Lines 9 to 12 in c0a9236

	//TODO: it looks not OOP
	void InitParameter(IDictionary<string, int> param);
	IDictionary<string, int> GetParameterDic();
	int FunctionTypeEnum { get; }

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

is this class still in use?

https://github.com/AElfProject/AElf/blob/c0a92361e4a38d5fc738072bc62b25fd16a9934b/src/AElf.Kernel.SmartContract/Application/ContractEventDiscoveryService{T}.cs#L15-L18

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

is still in use?

AElf/src/AElf.Kernel.SmartContract/Application/DeployContractAddressForkCacheHandler.cs

Lines 8 to 11 in c0a9236

	//TODO: is still in use?
	public class DeployContractAddressForkCacheHandler : IForkCacheHandler, ITransientDependency
	{
	private readonly IDeployedContractAddressProvider _deployedContractAddressProvider;

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

why in a SmartContract package, you put a Token class? if you create a door, can put a clock on the door,

AElf/src/AElf.Kernel.SmartContract/Application/ExtraAvailableTokenProvider.cs

Lines 3 to 7 in c0a9236

	//TODO: why in a SmartContract package, you put a Token class? if you create a door, can put a clock on the door,
	//And tell people, "I don't care about whether you need a clock or not, but I MADE the clock inside the door?"
	public class AvailableTokenInfoInCache
	{
	public string TokenSymbol { get; set; }

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

if you new a class, why not pass parameters by constructor? you know the type of calWayDic[func.PieceKey], but why don't you use strong signature?

AElf/src/AElf.Kernel.TransactionPool/Application/CalculateFeeService.cs

Lines 165 to 168 in c0a9236

	//TODO: if you new a class, why not pass parameters by constructor? you know the type of calWayDic[func.PieceKey], but why don't you use strong signature?
	calWayDic[func.PieceKey].InitParameter(funDicToLowerKey);
	}
	_cacheCacheProvider.SetPieceWiseFunctionToNormalCache(calWayDic);

---

This comment was generated by todo based on a TODO comment in c0a9236 in #2409. cc @AElfProject.

[todo]

a service should not mange status. what's this class for?

AElf/src/AElf.Kernel.Core/Txn/Application/TransactionPackingService.cs

Lines 6 to 9 in 40ce8b3

	//TODO: a service should not mange status. what's this class for?
	private bool _isTransactionPackable = true;
	public void EnableTransactionPacking()

---

This comment was generated by todo based on a TODO comment in 40ce8b3 in #2409. cc @AElfProject.

[todo]

is still in use?

AElf/src/AElf.Kernel.SmartContract/Application/DeployContractAddressForkCacheHandler.cs

Lines 8 to 11 in 40ce8b3

	//TODO: is still in use?
	public class DeployContractAddressForkCacheHandler : IForkCacheHandler, ITransientDependency
	{
	private readonly IDeployedContractAddressProvider _deployedContractAddressProvider;

---

This comment was generated by todo based on a TODO comment in 40ce8b3 in #2409. cc @AElfProject.

[todo]

why in a SmartContract package, you put a Token class? if you create a door, can put a clock on the door,

AElf/src/AElf.Kernel.SmartContract/Application/ExtraAvailableTokenProvider.cs

Lines 3 to 7 in 40ce8b3

	//TODO: why in a SmartContract package, you put a Token class? if you create a door, can put a clock on the door,
	//And tell people, "I don't care about whether you need a clock or not, but I MADE the clock inside the door?"
	public class AvailableTokenInfoInCache
	{
	public string TokenSymbol { get; set; }

---

This comment was generated by todo based on a TODO comment in 40ce8b3 in #2409. cc @AElfProject.

[todo]

if you new a class, why not pass parameters by constructor? you know the type of calWayDic[func.PieceKey], but why don't you use strong signature?

AElf/src/AElf.Kernel.TransactionPool/Application/CalculateFeeService.cs

Lines 165 to 168 in 40ce8b3

	//TODO: if you new a class, why not pass parameters by constructor? you know the type of calWayDic[func.PieceKey], but why don't you use strong signature?
	calWayDic[func.PieceKey].InitParameter(funDicToLowerKey);
	}
	_cacheCacheProvider.SetPieceWiseFunctionToNormalCache(calWayDic);

---

This comment was generated by todo based on a TODO comment in 40ce8b3 in #2409. cc @AElfProject.

[AppVeyorBot]

❌ Build AElf 1.0.0.6200 failed (commit c0acf98328 by @loning)