Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of afl-system-config.8 #441

Merged
merged 4 commits into from Jul 5, 2020

Conversation

bmwiedemann
Copy link
Contributor

Without this patch, afl-system-config.8 varied between build hosts
because it contained lines such as

 ./afl-system-config: line 30: sysctl: command not found
 ./afl-system-config: line 31: /sys/kernel/mm/transparent_hugepage/enabled: Permission denied
 It is recommended to boot the kernel with lots of security off

This PR was done while working on reproducible builds for openSUSE.

@vanhauser-thc
Copy link
Member

I this patch incomplete?

it only contains

- test "$1" = "-h" && {
+ test "$1" = "-h" -o "$1" = "-hh" && {

@bmwiedemann
Copy link
Contributor Author

bmwiedemann commented Jul 5, 2020

That is correct. See the %.8 target in the top GNUmakefile that calls commands with -hh to fill the OPTIONS section

It seems ./afl-whatsup -hh could also need some improvement, but at least it prints a usage.

and afl-whatsup.8

Without this patch, afl-system-config.8 varied between build hosts
because it contained lines such as
 ./afl-system-config: line 30: sysctl: command not found
 ./afl-system-config: line 31: /sys/kernel/mm/transparent_hugepage/enabled: Permission denied
 It is recommended to boot the kernel with lots of security off

See https://reproducible-builds.org/ for why this matters.

afl-system-config.8 is generated by the %.8 target in GNUmakefile
that calls commands with -hh to fill the OPTIONS section of man-pages.

This PR was done while working on reproducible builds for openSUSE.
@vanhauser-thc
Copy link
Member

ok.
please push to dev in the future, we do not accept PRs to stable/master.

@vanhauser-thc vanhauser-thc merged commit 8acc8b5 into AFLplusplus:dev Jul 5, 2020
@bmwiedemann bmwiedemann deleted the man branch July 5, 2020 19:25
abertschi pushed a commit to mattweingarten/AFLplusplus that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants