-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove observer_stdout/observer_stderr from Observer trait #2167
Conversation
/// | ||
/// If no `@@` was found, will use stdin for input. | ||
/// The arg 0 is the program. | ||
pub fn parse_afl_cmdline<IT, O>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want afl commandline anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
we should do everything with builder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the builder should then probably have a parse_afl_cmdline option, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i want to remove it because that specific "@@" parsing is specific to forkserver and this is not
…us#2167) * stuff * upd * cargo test * doc * fmt * nyx stuff
and change how command executor sets stuff up.