Remove observer_stdout/observer_stderr from Observer trait #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
May 13, 2024
| /// | ||
| /// If no `@@` was found, will use stdin for input. | ||
| /// The arg 0 is the program. | ||
| pub fn parse_afl_cmdline<IT, O>( |
There was a problem hiding this comment.
we don't want afl commandline anymore?
There was a problem hiding this comment.
no
we should do everything with builder
There was a problem hiding this comment.
the builder should then probably have a parse_afl_cmdline option, right?
There was a problem hiding this comment.
i want to remove it because that specific "@@" parsing is specific to forkserver and this is not
domenukk
reviewed
May 13, 2024
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
May 24, 2024
…us#2167) * stuff * upd * cargo test * doc * fmt * nyx stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and change how command executor sets stuff up.