This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
iOS Multitasking support #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: AFNetworking/AFHTTPClient.m AFNetworking/AFHTTPRequestOperation.m AFNetworking/AFJSONRequestOperation.m AFNetworking/AFXMLRequestOperation.m AFNetworking/NSString+AFNetworking.h Example/Classes/AFGowallaAPIClient.h Mac Example/AppDelegate.h Mac Example/AppDelegate.m Mac Example/Classes/AFGowallaAPIClient.h iOS Example/Classes/AFGowallaAPIClient.h
…rking Conflicts: AFNetworking/AFHTTPClient.m AFNetworking/AFHTTPRequestOperation.h AFNetworking/AFHTTPRequestOperation.m AFNetworking/AFJSONRequestOperation.h AFNetworking/AFJSONRequestOperation.m AFNetworking/AFPropertyListRequestOperation.h AFNetworking/AFPropertyListRequestOperation.m AFNetworking/AFXMLRequestOperation.h AFNetworking/AFXMLRequestOperation.m
…ed to be the delegate.
…rking Conflicts: AFNetworking/AFJSONUtilities.h
…rking Conflicts: AFNetworking/AFHTTPClient.m
Conflicts: AFNetworking/AFHTTPClient.m AFNetworking/AFImageRequestOperation.h AFNetworking/AFImageRequestOperation.m AFNetworking/AFJSONRequestOperation.h AFNetworking/AFXMLRequestOperation.m
…parent have a say in the isReady process so it can check dependent NSOperations.
…ng their responses. Dependent operations may need the response after one has completed. This also simplifies things a little.
|
Thanks for sharing these changes. I'm not sure if this functionality wouldn't be better-suited for |
|
you're right. we have a better approach. going to push it later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added support for iOS multitasking in our branch. It's completely optional by setting
requestOperation.attemptToContinueWhenAppEntersBackground = YES;Commit seatme/AFNetworking@d56f873bc has most of the changes. This is a little more tricky of a patch to integrate upstream because it's dependent on the changes we made to handle success/failure callbacks but in your model, you could solve this possibly in the base version of setCompletionBlockWithSuccessBlock:FailureBlock concept (actually I don't know if this is in base class like us but it could be).
Originally we did this at the AFURLRequestOperation level but we moved it up to the AFHTTPRequestOperation level because we want to make sure that the the task is ended after the success and failure callbacks have returned to give the caller a chance to something before allowing the app to shut down. You could move it back down to AFURLRequstionOperation by handling the endBackgroundTask call in the completionBlock but that may not work in your model since you should really end the task after the dispatched async callback for the success and failure blocks so they have a chance to run.
Either way. Interesting changes I wanted share upstream.