This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixed a leak of AFHTTPRequestOperation in setCompletionBlock: #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a block object to reference self in the completion block - Added a pointer to the onceToken to be used in the completion block
|
Huh, yeah, that would do it. Thanks for the patch, and thanks to @note173 for spotting the issue. |
mattt
pushed a commit
that referenced
this pull request
Apr 15, 2012
…-fix Fixed a leak of AFHTTPRequestOperation in setCompletionBlock:
greghe
pushed a commit
to skillz/AFNetworking
that referenced
this pull request
Sep 3, 2015
…eration-leak-fix Fixed a leak of AFHTTPRequestOperation in setCompletionBlock:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a leak that was introduced when I submitted the pull request #288. The
setCompletionBlock:method was creating a retain cycle for the operation and so the operation was never being deallocated.The way this was fixed was to add a reference to self that is declared as
__blockvariabel so that it would not be retained by the block. Also a local reference to the_onceTokenwas made since accessing an instance variable by reference within a block also retains self.Credit goes to @note173 who found the issue (#301) and proposed the fix that is in this pull request.