New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XMLParser/XMLDocument serializer tests #3753

Merged
merged 3 commits into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@skyline75489
Contributor

skyline75489 commented Oct 14, 2016

Inspired by 290ec35, this adds tests for AFXMLParserResponseSerializer and AFXMLDocumentResponseSerializer. This also fixes an error in AFXMLDocumentResponseSerializer documentation.

@@ -166,7 +166,7 @@ NS_ASSUME_NONNULL_BEGIN
- (instancetype)init;
/**
Input and output options specifically intended for `NSXMLDocument` objects. For possible values, see the `NSJSONSerialization` documentation section "NSJSONReadingOptions". `0` by default.
Input and output options specifically intended for `NSXMLDocument` objects. For possible values, see the `NSXMLDocument` documentation section "Input and Output Options". `0` by default.

This comment has been minimized.

@skyline75489

skyline75489 Oct 14, 2016

Contributor

This looks like a copy-and-paste error for me.

@skyline75489

skyline75489 Oct 14, 2016

Contributor

This looks like a copy-and-paste error for me.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 15, 2016

Codecov Report

Merging #3753 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3753      +/-   ##
==========================================
+ Coverage   86.95%   87.23%   +0.27%     
==========================================
  Files          45       46       +1     
  Lines        5505     5539      +34     
  Branches      439      439              
==========================================
+ Hits         4787     4832      +45     
+ Misses        715      704      -11     
  Partials        3        3
Impacted Files Coverage Δ
AFNetworking/AFURLResponseSerialization.h 90% <ø> (ø) ⬆️
Tests/Tests/AFXMLParserResponseSerializerTests.m 100% <100%> (ø)
AFNetworking/AFURLResponseSerialization.m 88.75% <0%> (+3.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5c955...158dc56. Read the comment docs.

codecov-io commented Oct 15, 2016

Codecov Report

Merging #3753 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3753      +/-   ##
==========================================
+ Coverage   86.95%   87.23%   +0.27%     
==========================================
  Files          45       46       +1     
  Lines        5505     5539      +34     
  Branches      439      439              
==========================================
+ Hits         4787     4832      +45     
+ Misses        715      704      -11     
  Partials        3        3
Impacted Files Coverage Δ
AFNetworking/AFURLResponseSerialization.h 90% <ø> (ø) ⬆️
Tests/Tests/AFXMLParserResponseSerializerTests.m 100% <100%> (ø)
AFNetworking/AFURLResponseSerialization.m 88.75% <0%> (+3.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5c955...158dc56. Read the comment docs.

@SlaunchaMan

Looks good! More tests are always appreciated!

@skyline75489

This comment has been minimized.

Show comment
Hide comment
@skyline75489

skyline75489 Nov 23, 2017

Contributor

@SlaunchaMan Would you mind merging this PR & #3750 which were drafted a long time ago

Contributor

skyline75489 commented Nov 23, 2017

@SlaunchaMan Would you mind merging this PR & #3750 which were drafted a long time ago

@SlaunchaMan SlaunchaMan merged commit 9d5a894 into AFNetworking:master Nov 23, 2017

3 checks passed

codecov/patch 100% of diff hit (target 86.95%)
Details
codecov/project 87.23% (+0.27%) compared to ec5c955
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SlaunchaMan SlaunchaMan added this to the 3.2.0 milestone Dec 15, 2017

@SlaunchaMan SlaunchaMan added tests updated added and removed updated labels Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment