New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation for supported encodings in AFJSONResponseSerializer #3750

Merged
merged 3 commits into from Nov 24, 2017

Conversation

Projects
None yet
5 participants
@skyline75489
Contributor

skyline75489 commented Oct 13, 2016

This clarify the data encoding needed for AFJSONResponseSerializer to successfully parsing the response as JSON object.

@kcharwood kcharwood changed the title from Clarify documentation for supported encodings in AFJSONResponseSerial… to Clarify documentation for supported encodings in AFJSONResponseSerializer Oct 13, 2016

@kcharwood kcharwood added the updated label Oct 13, 2016

@kcharwood kcharwood added this to the 3.2.0 milestone Oct 13, 2016

@SlaunchaMan

This comment has been minimized.

Show comment
Hide comment
@SlaunchaMan

SlaunchaMan Nov 23, 2017

Member

@skyline75489 Can you merge in master or rebase off of it to get the build to pass on Travis?

Member

SlaunchaMan commented Nov 23, 2017

@skyline75489 Can you merge in master or rebase off of it to get the build to pass on Travis?

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 23, 2017

Codecov Report

Merging #3750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3750   +/-   ##
======================================
  Coverage    82.8%   82.8%           
======================================
  Files          46      46           
  Lines        5304    5304           
  Branches      439     439           
======================================
  Hits         4392    4392           
  Misses        671     671           
  Partials      241     241
Impacted Files Coverage Δ
AFNetworking/AFURLResponseSerialization.h 90% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5a894...8ad7050. Read the comment docs.

codecov-io commented Nov 23, 2017

Codecov Report

Merging #3750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3750   +/-   ##
======================================
  Coverage    82.8%   82.8%           
======================================
  Files          46      46           
  Lines        5304    5304           
  Branches      439     439           
======================================
  Hits         4392    4392           
  Misses        671     671           
  Partials      241     241
Impacted Files Coverage Δ
AFNetworking/AFURLResponseSerialization.h 90% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5a894...8ad7050. Read the comment docs.

@skyline75489

This comment has been minimized.

Show comment
Hide comment
@skyline75489
Contributor

skyline75489 commented Nov 23, 2017

@SlaunchaMan Done.

@SlaunchaMan SlaunchaMan merged commit 4de1156 into AFNetworking:master Nov 24, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 9d5a894...8ad7050
Details
codecov/project 82.8% remains the same compared to 9d5a894
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment