New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return value of HTTP redirection block to be NULL #3975

Merged
merged 2 commits into from Jul 22, 2017

Conversation

Projects
None yet
4 participants
@TheDom
Contributor

TheDom commented Jun 21, 2017

This addresses #3974

@SlaunchaMan

This comment has been minimized.

Show comment
Hide comment
@SlaunchaMan

SlaunchaMan Jul 13, 2017

Member

Thanks for the PR! Can you merge in master or rebase so that the tests pass?

Member

SlaunchaMan commented Jul 13, 2017

Thanks for the PR! Can you merge in master or rebase so that the tests pass?

Make tests pass again (#3993)
* Make tests pass again

* Fix macOS builds in Fastlane.
@TheDom

This comment has been minimized.

Show comment
Hide comment
@TheDom

TheDom Jul 13, 2017

Contributor

Done! :)

Contributor

TheDom commented Jul 13, 2017

Done! :)

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 13, 2017

Codecov Report

Merging #3975 into master will decrease coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3975      +/-   ##
==========================================
- Coverage   87.44%   86.95%   -0.49%     
==========================================
  Files          45       45              
  Lines        6227     5505     -722     
  Branches      416      439      +23     
==========================================
- Hits         5445     4787     -658     
+ Misses        779      715      -64     
  Partials        3        3
Impacted Files Coverage Δ
AFNetworking/AFURLSessionManager.h 87.5% <ø> (ø) ⬆️
Tests/Tests/AFSecurityPolicyTests.m 100% <100%> (ø) ⬆️
UIKit+AFNetworking/UIButton+AFNetworking.m 77.14% <0%> (-4.15%) ⬇️
UIKit+AFNetworking/UIRefreshControl+AFNetworking.m 70.73% <0%> (-3.69%) ⬇️
AFNetworking/AFHTTPSessionManager.m 88.96% <0%> (-2.14%) ⬇️
UIKit+AFNetworking/UIWebView+AFNetworking.m 76.92% <0%> (-1.65%) ⬇️
AFNetworking/AFURLRequestSerialization.m 70.64% <0%> (-1.63%) ⬇️
AFNetworking/AFURLResponseSerialization.m 85.5% <0%> (-1.37%) ⬇️
AFNetworking/AFURLSessionManager.m 69.38% <0%> (-1.29%) ⬇️
AFNetworking/AFNetworkReachabilityManager.m 71.9% <0%> (-1.29%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3c694...e037436. Read the comment docs.

codecov-io commented Jul 13, 2017

Codecov Report

Merging #3975 into master will decrease coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3975      +/-   ##
==========================================
- Coverage   87.44%   86.95%   -0.49%     
==========================================
  Files          45       45              
  Lines        6227     5505     -722     
  Branches      416      439      +23     
==========================================
- Hits         5445     4787     -658     
+ Misses        779      715      -64     
  Partials        3        3
Impacted Files Coverage Δ
AFNetworking/AFURLSessionManager.h 87.5% <ø> (ø) ⬆️
Tests/Tests/AFSecurityPolicyTests.m 100% <100%> (ø) ⬆️
UIKit+AFNetworking/UIButton+AFNetworking.m 77.14% <0%> (-4.15%) ⬇️
UIKit+AFNetworking/UIRefreshControl+AFNetworking.m 70.73% <0%> (-3.69%) ⬇️
AFNetworking/AFHTTPSessionManager.m 88.96% <0%> (-2.14%) ⬇️
UIKit+AFNetworking/UIWebView+AFNetworking.m 76.92% <0%> (-1.65%) ⬇️
AFNetworking/AFURLRequestSerialization.m 70.64% <0%> (-1.63%) ⬇️
AFNetworking/AFURLResponseSerialization.m 85.5% <0%> (-1.37%) ⬇️
AFNetworking/AFURLSessionManager.m 69.38% <0%> (-1.29%) ⬇️
AFNetworking/AFNetworkReachabilityManager.m 71.9% <0%> (-1.29%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3c694...e037436. Read the comment docs.

@SlaunchaMan

This comment has been minimized.

Show comment
Hide comment
@SlaunchaMan

SlaunchaMan Jul 15, 2017

Member

@jshier This should be good to merge!

Member

SlaunchaMan commented Jul 15, 2017

@jshier This should be good to merge!

@jshier

This comment has been minimized.

Show comment
Hide comment
@jshier

jshier Jul 15, 2017

Contributor

@SlaunchaMan Any idea why the diff is showing cert changes? Otherwise it looks good.

Contributor

jshier commented Jul 15, 2017

@SlaunchaMan Any idea why the diff is showing cert changes? Otherwise it looks good.

@SlaunchaMan

This comment has been minimized.

Show comment
Hide comment
@SlaunchaMan

SlaunchaMan Jul 15, 2017

Member

I’m pretty sure that’s just from master being merged in. Feel free to cherry-pick and close if that’s cleaner.

Member

SlaunchaMan commented Jul 15, 2017

I’m pretty sure that’s just from master being merged in. Feel free to cherry-pick and close if that’s cleaner.

@jshier jshier merged commit dd59ffa into AFNetworking:master Jul 22, 2017

3 checks passed

codecov/patch 100% of diff hit (target 87.44%)
Details
codecov/project Absolute coverage decreased by -0.48% but relative coverage increased by +12.55% compared to 4f3c694
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

viennhn added a commit to viennhn/AFNetworking that referenced this pull request Aug 21, 2017

@SlaunchaMan SlaunchaMan added this to the 3.2.0 milestone Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment