Class refactor for clearer view #23

Seluj78 · 2019-12-10T20:05:57Z

output diff: https://www.diffchecker.com/jBPi159w

Will close #11

deronnax

je kiff à domf ce refactoring. En lisant le nouveau code, je comprends à peu près ce qu'il fait, ce qui n'était pas le cas de l'ancien 🙃

potodo/potodo.py

@deronnax

cc @deronnax. It is commited in another branch for later.

awecx

J'ai relu de très loin sans chercher à comprendre.
Je t'ai mis 2-3 remarques de style, je relirai une fois demain pour le fond.

potodo/_github.py

potodo/_po_file.py

potodo/_github.py

potodo/potodo.py

Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>

Although have to convert to string as it returns bytes...

potodo/_github.py

pyproject.toml

potodo/potodo.py

JulienPalard · 2019-12-11T11:07:17Z

I think we should merge #19 before refactoring everything.

potodo/_github.py

potodo/_po_file.py

@JulienPalard

cc @JulienPalard

potodo/_po_file.py

Based on code review feedback

potodo/_github.py

…nces

potodo/potodo.py

Seluj78 · 2019-12-11T21:11:36Z

🎉

awecx · 2019-12-11T21:12:17Z

Ayaaa je commençais à lire.

Seluj78 · 2019-12-11T21:12:53Z

🤷‍♂ T'es lent :p Lit le code et fait une PR/issue ?

JulienPalard · 2019-12-11T21:14:14Z

@awecx oh t'es même pas sur #python-docs-fr sur freenode :]

Seluj78 added 4 commits December 10, 2019 15:38

Class refactoring WIP

9f2bc03

Added new PoFile vars

7a7b2cf

Big refactor + disabled matching files

14fbdd3

Version bump

2f506ea

Seluj78 added the enhancement New feature or request label Dec 10, 2019

Seluj78 requested review from JulienPalard, deronnax and awecx December 10, 2019 20:05

Seluj78 self-assigned this Dec 10, 2019

This was referenced Dec 10, 2019

Reinstate -l --matched-files #24

Closed

Print the number of entries to do instead of percent done #19

Closed

do not report fuzzies located in commented blocks #16

Closed

do not use f-string #17

Closed

Removed useless code and one useless TODO

90d8458

deronnax previously approved these changes Dec 10, 2019

View reviewed changes

potodo/potodo.py Outdated Show resolved Hide resolved

Seluj78 added 3 commits December 10, 2019 23:08

Removed commented code

f46e5a9

cc @deronnax. It is commited in another branch for later.

Added comments

21fe4c4

Blackified the code

f8d352f

Seluj78 dismissed deronnax’s stale review via f8d352f December 10, 2019 22:22

Seluj78 requested a review from deronnax December 10, 2019 22:23

awecx reviewed Dec 10, 2019

View reviewed changes

Seluj78 and others added 4 commits December 10, 2019 23:47

Added type hinting + black project config

ba196ff

Apply suggestions from code review

7307a10

Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>

Feedback from @awecx.

0705eba

Although have to convert to string as it returns bytes...

More feedback from @awecx

658ee23

Seluj78 requested a review from awecx December 10, 2019 22:56

JulienPalard reviewed Dec 11, 2019

View reviewed changes

potodo/_github.py Outdated Show resolved Hide resolved

JulienPalard reviewed Dec 11, 2019

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

JulienPalard reviewed Dec 11, 2019

View reviewed changes

potodo/potodo.py Outdated Show resolved Hide resolved

Seluj78 mentioned this pull request Dec 11, 2019

Added pagination for issues API #20

Merged

JulienPalard reviewed Dec 11, 2019

View reviewed changes

potodo/_github.py Outdated Show resolved Hide resolved

potodo/_github.py Outdated Show resolved Hide resolved

potodo/_github.py Outdated Show resolved Hide resolved

potodo/_github.py Outdated Show resolved Hide resolved

potodo/_po_file.py Outdated Show resolved Hide resolved

Fixes from code review

fd4dacc

JulienPalard reviewed Dec 11, 2019

View reviewed changes

potodo/_po_file.py Outdated Show resolved Hide resolved

Seluj78 added 4 commits December 11, 2019 19:56

Standard docstrings + black

cfa396d

cc @JulienPalard

class PoFile -> PoFileStats

76654b3

Fixed string replacing problem

36ff67e

Changed return type to Mapping

d4fb2fe

Seluj78 commented Dec 11, 2019

View reviewed changes

potodo/_po_file.py Outdated Show resolved Hide resolved

Seluj78 added 4 commits December 11, 2019 20:16

Changed return type hint form dict to mapping

4704aff

Based on code review feedback

Removed useless code

b05b7bf

Back to str.replace()

8dfd0b8

Update potodo/_po_file.py

20427b8

JulienPalard reviewed Dec 11, 2019

View reviewed changes

potodo/_github.py Outdated Show resolved Hide resolved

JulienPalard reviewed Dec 11, 2019

View reviewed changes

potodo/_github.py Outdated Show resolved Hide resolved

Update potodo/_github.py

0702d50

JulienPalard reviewed Dec 11, 2019

View reviewed changes

potodo/_github.py Outdated Show resolved Hide resolved

Seluj78 added 4 commits December 11, 2019 21:50

Followed code review. Removed useless type annotation

1ff37ba

Merge remote-tracking branch 'origin/class-refactor' into class-refactor

0faea86

Removed another useless type anotation

140f7b6

Black, mypy and removed useless returns as lists are passed as refere…

1feda28

…nces

Seluj78 commented Dec 11, 2019

View reviewed changes

potodo/potodo.py Show resolved Hide resolved

Fixed mypy error

4b03d33

JulienPalard approved these changes Dec 11, 2019

View reviewed changes

Seluj78 merged commit 291739d into master Dec 11, 2019

Seluj78 deleted the class-refactor branch December 11, 2019 21:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Class refactor for clearer view #23

Class refactor for clearer view #23

Seluj78 commented Dec 10, 2019 •

edited

Loading

deronnax left a comment

awecx left a comment

JulienPalard commented Dec 11, 2019

Seluj78 commented Dec 11, 2019

awecx commented Dec 11, 2019

Seluj78 commented Dec 11, 2019

JulienPalard commented Dec 11, 2019

Class refactor for clearer view #23

Class refactor for clearer view #23

Conversation

Seluj78 commented Dec 10, 2019 • edited Loading

deronnax left a comment

Choose a reason for hiding this comment

awecx left a comment

Choose a reason for hiding this comment

JulienPalard commented Dec 11, 2019

Seluj78 commented Dec 11, 2019

awecx commented Dec 11, 2019

Seluj78 commented Dec 11, 2019

JulienPalard commented Dec 11, 2019

Seluj78 commented Dec 10, 2019 •

edited

Loading